Hi Folks,
for our project we needed support for texture files and have built it into Openmesh and also exposed it in openmesh-python.
What we did in detail:
OpenMesh:
- added param 'texture_file' to the Options class, it specifies the path to the texture file - added param 'material_file_extension' to the Options class, it specifies the material file suffix, default is ".mat" as it was before, we needed it becuase Blender expects ".mtl" - removed default and copy constructor and destructor as well as assignment operator, because these are not necessary here, see https://en.cppreference.com/w/cpp/language/rule_of_three
openmesh-python: - exposed the above features - exposed .is_locked and .set_locked - documented it in trimesh.rst
I attatched the git diffs for OpenMesh and openmesh-python.
Please let me know if it could be merged and if necessary what we could do better ;)
regards
Philipp Auersperg-Castell
Hi,
is there any chance this patches get merged upstream? Do you need additional changes/information?
Thanks
-Robert
On 3/7/22 09:31, Robert Niederreiter wrote:
Hi,
is there any chance this patches get merged upstream? Do you need additional changes/information?
Thanks
-Robert
Hi,
sorry i completely missed that patch. The OpenMesh part is now tracked in this merge request
https://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/merge_requests/31...
Python might take a little longer as I'm currently updating the CI runners with newer python versions.
Regards, Jan Möbius
Hi,
both patches have been merged.
Regards, Jan Möbius
On 3/7/22 09:31, Robert Niederreiter wrote:
Hi,
is there any chance this patches get merged upstream? Do you need additional changes/information?
Thanks
-Robert
Hi,
On 07.03.22 14:24, Jan Möbius wrote:
Hi,
both patches have been merged.
Awesome! Thank you!
-Robert
Regards, Jan Möbius
On 3/7/22 09:31, Robert Niederreiter wrote:
Hi,
is there any chance this patches get merged upstream? Do you need additional changes/information?
Thanks
-Robert