Dear OpenMesh maintainers,
We encountered a configuration where PolyConnectivity::is_collapse_ok fails to return a correct result for a triangle mesh, while TriConnectivity::is_collapse_ok does.
We attach code to reproduce the problem (openmesh_bug_is_collapse_ok.cpp). See the comments in that file for more details on the bug. Moreover, we attach a patch against OpenMesh-7.1 to fix the problem (openmesh_patch_is_collapse_ok.patch). The patch basically reproduces the logic of TriConnectivity::is_collapse_ok for this special case.
Not related, but did you have time to look at this issue https://lists.rwth-aachen.de/hyperkitty/list/openmesh@lists.rwth-aachen.de/t... we reported some time ago?
thanks, Simon
Hi,
thanks for the patch. It's currently in our CI and should be added to master soon.
The other one is a bit complicated. I added an issue for that so that i don't forget about it again: https://graphics.rwth-aachen.de:9000/OpenMesh/OpenMesh/issues/61
Best, Jan Möbius
On 05.10.18 14:59, Simon Flöry wrote:
Dear OpenMesh maintainers,
We encountered a configuration where PolyConnectivity::is_collapse_ok fails to return a correct result for a triangle mesh, while TriConnectivity::is_collapse_ok does.
We attach code to reproduce the problem (openmesh_bug_is_collapse_ok.cpp). See the comments in that file for more details on the bug. Moreover, we attach a patch against OpenMesh-7.1 to fix the problem (openmesh_patch_is_collapse_ok.patch). The patch basically reproduces the logic of TriConnectivity::is_collapse_ok for this special case.
Not related, but did you have time to look at this issue https://lists.rwth-aachen.de/hyperkitty/list/openmesh@lists.rwth-aachen.de/t...
we reported some time ago?
thanks, Simon
-
Jan Möbius -
Simon Flöry