Hi devs,
you added the sdl_display.hpp to the example folder examples/linux/gui/sdl_display.hpp
But the SDL display already existed as class of xpcc under #include <xpcc/architecture/platform/hosted/linux/display/sdl_display.hpp>. The additional functionality of this class should have been added there and then this class should be included in the example instead of copying the class files to the example folder.
Best Regards, Thorsten
Hi Thorsten,
On Wed 05 Mar 2014 07:13:30 PM CET, Thorsten Lajewski wrote:
But the SDL display already existed as class of xpcc under #include <xpcc/architecture/platform/hosted/linux/display/sdl_display.hpp>. The additional functionality of this class should have been added there and then this class should be included in the example instead of copying the class files to the example folder.
You are right. Daniel did this yesterday. I was talking to him when he was leaving and told him that there was already a sdl_display class in xpcc. It's only on his feature branch and I guess he will revert the commit eventually. But thanks for pointing that out.
Kevin
-
Kevin Laeufer -
Thorsten Lajewski