texture file support
Hi Folks, for our project we needed support for texture files and have built it into Openmesh and also exposed it in openmesh-python. What we did in detail: OpenMesh: - added param 'texture_file' to the Options class, it specifies the path to the texture file - added param 'material_file_extension' to the Options class, it specifies the material file suffix, default is ".mat" as it was before, we needed it becuase Blender expects ".mtl" - removed default and copy constructor and destructor as well as assignment operator, because these are not necessary here, see https://en.cppreference.com/w/cpp/language/rule_of_three openmesh-python: - exposed the above features - exposed .is_locked and .set_locked - documented it in trimesh.rst I attatched the git diffs for OpenMesh and openmesh-python. Please let me know if it could be merged and if necessary what we could do better ;) regards Philipp Auersperg-Castell
Hi, is there any chance this patches get merged upstream? Do you need additional changes/information? Thanks -Robert -- Squarewave Computing Robert Niederreiter Aflingerstraße 19 A-6176 Völs www.squarewave.at +43 699 160 20 192 ATU61774100
On 3/7/22 09:31, Robert Niederreiter wrote:
Hi,
is there any chance this patches get merged upstream? Do you need additional changes/information?
Thanks
-Robert
Hi, sorry i completely missed that patch. The OpenMesh part is now tracked in this merge request https://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/merge_requests/31... Python might take a little longer as I'm currently updating the CI runners with newer python versions. Regards, Jan Möbius -- Jan Möbius Department of Computer Science VIII Aachen University of Technology (RWTH) Ahornstrasse 55, 52074 Aachen, Germany Phone ++49 (0)241 80-21802 Fax ++49 (0)241 80-22899 mailto:moebius@cs.rwth-aachen.de http://www.rwth-graphics.de
Hi, both patches have been merged. Regards, Jan Möbius On 3/7/22 09:31, Robert Niederreiter wrote:
Hi,
is there any chance this patches get merged upstream? Do you need additional changes/information?
Thanks
-Robert
-- Jan Möbius Department of Computer Science VIII Aachen University of Technology (RWTH) Ahornstrasse 55, 52074 Aachen, Germany Phone ++49 (0)241 80-21802 Fax ++49 (0)241 80-22899 mailto:moebius@cs.rwth-aachen.de http://www.rwth-graphics.de
Hi, On 07.03.22 14:24, Jan Möbius wrote:
Hi,
both patches have been merged.
Awesome! Thank you! -Robert
Regards, Jan Möbius
On 3/7/22 09:31, Robert Niederreiter wrote:
Hi,
is there any chance this patches get merged upstream? Do you need additional changes/information?
Thanks
-Robert
-- Squarewave Computing Robert Niederreiter Aflingerstraße 19 A-6176 Völs www.squarewave.at +43 699 160 20 192 ATU61774100
participants (3)
-
Jan Möbius -
Philipp Auersperg-Castell -
Robert Niederreiter