[PATCH] PolyConnectivity::is_collapse_ok fails

Dear OpenMesh maintainers, We encountered a configuration where PolyConnectivity::is_collapse_ok fails to return a correct result for a triangle mesh, while TriConnectivity::is_collapse_ok does. We attach code to reproduce the problem (openmesh_bug_is_collapse_ok.cpp). See the comments in that file for more details on the bug. Moreover, we attach a patch against OpenMesh-7.1 to fix the problem (openmesh_patch_is_collapse_ok.patch). The patch basically reproduces the logic of TriConnectivity::is_collapse_ok for this special case. Not related, but did you have time to look at this issue https://lists.rwth-aachen.de/hyperkitty/list/openmesh@lists.rwth-aachen.de/t... we reported some time ago? thanks, Simon -- Dr. Simon Flöry Rechenraum e.U. Stutterheimstraße 16-18/2/20a, 1150 Wien, Austria phone: +43 (0)1 789061269 mobile: +43 (0)681 81502316 skype: simon.floery Commercial Register No. FN 385715d (Handelsgericht Wien) This e-mail contains confidential information. If you are not the intended recipient, you must not disclose nor use the contents of this e-mail. In case you have received this e-mail in error, we ask you to inform us and delete this e-mail.

Hi, thanks for the patch. It's currently in our CI and should be added to master soon. The other one is a bit complicated. I added an issue for that so that i don't forget about it again: https://graphics.rwth-aachen.de:9000/OpenMesh/OpenMesh/issues/61 Best, Jan Möbius On 05.10.18 14:59, Simon Flöry wrote:
Dear OpenMesh maintainers,
We encountered a configuration where PolyConnectivity::is_collapse_ok fails to return a correct result for a triangle mesh, while TriConnectivity::is_collapse_ok does.
We attach code to reproduce the problem (openmesh_bug_is_collapse_ok.cpp). See the comments in that file for more details on the bug. Moreover, we attach a patch against OpenMesh-7.1 to fix the problem (openmesh_patch_is_collapse_ok.patch). The patch basically reproduces the logic of TriConnectivity::is_collapse_ok for this special case.
Not related, but did you have time to look at this issue https://lists.rwth-aachen.de/hyperkitty/list/openmesh@lists.rwth-aachen.de/t...
we reported some time ago?
thanks, Simon
-- Jan Möbius Department of Computer Science VIII Aachen University of Technology (RWTH) Ahornstrasse 55, 52074 Aachen, Germany Phone ++49 (0)241 80-21802 Fax ++49 (0)241 80-22899 mailto:moebius@cs.rwth-aachen.de http://www.rwth-graphics.de
participants (2)
-
Jan Möbius
-
Simon Flöry